Thread (15 messages) 15 messages, 4 authors, 2020-10-14

Re: [PATCH v3 2/5] media: dt-bindings: media: renesas,drif: Convert to json-schema

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2020-10-14 13:40:10
Also in: linux-media, linux-renesas-soc, lkml

Hi Fabrizio,

On Tue, Oct 13, 2020 at 5:02 PM Fabrizio Castro
[off-list ref] wrote:
Convert the Renesas DRIF bindings to DT schema and update
MAINTAINERS accordingly.

Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
v2->3:
* Removed the definition of pinctrl-0 and pinctrl-names, as
  suggested by Geert
* Added "power-domains" to the list of required properties,
  as suggested by Geert
* Reworked the conditional requirements, Geert, what do you
  think?
Thanks for the update!

quoted hunk ↗ jump to hunk
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml
+allOf:
+  - if:
+      required:
+        - renesas,primary-bond
+    then:
+      required:
+        - pinctrl-0
+        - pinctrl-names
+        - port
+
+  - if:
+      required:
+        - port
+    then:
+      required:
+        - pinctrl-0
+        - pinctrl-names
+
+  - if:
+      not:
+        required:
+          - port
+    then:
This can just be an "else" branch for the previous "if" statement?
+      properties:
+        pinctrl-0: false
+        pinctrl-names: false
With the above fixed/clarified:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help