Hi Geert,

On Fri, Sep 25, 2020 at 2:48 PM Geert Uytterhoeven [off-list ref] wrote:

Hi Mateusz,

On Wed, Sep 23, 2020 at 12:09 PM Mateusz Holenko [off-list ref] wrote:

quoted

From: Pawel Czarnecki <redacted>

Add documentation for LiteX SoC Controller bindings.

Signed-off-by: Pawel Czarnecki <redacted>
Signed-off-by: Mateusz Holenko <mholenko@antmicro.com>
Reviewed-by: Rob Herring <robh@kernel.org>

Thanks for your patch!

Thanks for your comments!

quoted

--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/litex/litex,soc-controller.yaml

@@ -0,0 +1,39 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+# Copyright 2020 Antmicro <www.antmicro.com>
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/soc/litex/litex,soc-controller.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: LiteX SoC Controller driver
+
+description: |
+  This is the SoC Controller driver for the LiteX SoC Builder.
+  It's purpose is to verify LiteX CSR (Control&Status Register) access

Its

quoted

+  operations and provide function for other drivers to read/write CSRs

functions

quoted

+  and to check if those accessors are ready to use.

be used

I will fix the description as suggested.

quoted

+
+maintainers:
+  - Karol Gugala [off-list ref]
+  - Mateusz Holenko [off-list ref]
+
+properties:
+  compatible:
+    const: litex,soc-controller
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+examples:
+  - |
+    soc_ctrl0: soc-controller@f0000000 {
+        compatible = "litex,soc-controller";
+        reg = <0xf0000000 0xC>;

Please be consistent w.r.t. lower/upper case: "0xc".

Sure, I will use lowercase everywhere.

quoted

+        status = "okay";
+    };

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Best regards,
Mateusz


--
Mateusz Holenko
Antmicro Ltd | www.antmicro.com
Roosevelta 22, 60-829 Poznan, Poland