Re: [PATCH v6 2/3] irqchip: Add Actions Semi Owl SIRQ controller

On Mon, Sep 14, 2020 at 10:19:31AM +0100, Marc Zyngier wrote:

On 2020-09-14 09:51, Cristian Ciocaltea wrote:

quoted

On Mon, Sep 14, 2020 at 09:07:18AM +0100, Marc Zyngier wrote:

quoted

Cristian,

On 2020-09-14 08:02, Cristian Ciocaltea wrote:

quoted

Hi Marc,

On Fri, Sep 11, 2020 at 05:22:41PM +0100, Marc Zyngier wrote:

quoted

On 2020-09-08 09:20, Cristian Ciocaltea wrote:

quoted

This interrupt controller is found in the Actions Semi Owl SoCs (S500,
S700 and S900) and provides support for handling up to 3 external
interrupt lines.

Each line can be independently configured as interrupt and triggers on
either of the edges or either of the levels. Additionally, each line
can also be masked individually.

The patch is based on the work started by Parthiban Nallathambi:
https://lore.kernel.org/lkml/20181126100356.2840578-1-pn@denx.de/ (local)

Signed-off-by: Parthiban Nallathambi <redacted>
Signed-off-by: Saravanan Sekar <sravanhome@gmail.com>
[cristi: optimized DT, various fixes/cleanups/improvements]
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>

Who is the author of these patches? If this is a co-development,
please
use the relevant tags. Otherwise, the author of the patch must come as
the first SoB.

I took the authorship for the driver patch, as mentioned in the cover
letter. So, if I understand correctly, my SoB should be moved on top and
I assume I also need to drop the related comment line.

Not quite. Please look at
Documentation/process/submitting-patches.rst.

Yes, I have read it, but most probably I missed the information that
clarifies this authorship change handling.

quoted

If Parthiban and Saravanan haven't authored anything in this patch,
then drop them from the SoB list.

Sorry I haven't properly explained this before!

Their contributions to the driver code stopped in 2018, when v3 of the
patch series has been submitted.

quoted

If they have contributed to the
patch (which I expect), then their SoB must be preceded by their own
Co-developed-by: tag.

Starting with v4, the work has been done exclusively by myself.

quoted

To sum it up, it probably should look like:

Co-developed-by: Parthiban Nallathambi <redacted>
Signed-off-by: Parthiban Nallathambi <redacted>
Co-developed-by: Saravanan Sekar <sravanhome@gmail.com>
Signed-off-by: Saravanan Sekar <sravanhome@gmail.com>
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>

This is of course an assumption, and you should check it with the
individuals above.

I have recently contacted Parthiban and he agreed that I can take the
authorship. So I should proceed with the 1st approach?

The authorship of the patch is one thing, acknowledging the work done
by others is another. As you said above, you started by contributing to
an existing series, instead of writing it from scratch. You changed it
to a degree where it makes sense for you to be the author of the patches,
but it doesn't invalidate the contributions made by others before you.

Unless the two other contributors explicitly say they'd rather not be
named, I don't see how you can avoid mentioning them.

 
I just want to do the right thing and follow the recommended procedure.
That's why I initially kept all the SoBs, but obviously I still missed
some bits and pieces, as you have pointed out.

So I will add the indicated Co-developed-by tags and resend the series.

Thanks,

      M.
-- 
Jazz is not dead. It just smells funny...

Thanks a lot for all the clarifications,
Cristi