Re: [PATCH 1/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

It was <2020-08-26 śro 15:06>, when David Laight wrote:

From: Lukasz Stelmach

quoted

Sent: 26 August 2020 15:59

It was <2020-08-25 wto 20:44>, when Krzysztof Kozlowski wrote:

quoted

On Tue, Aug 25, 2020 at 07:03:09PM +0200, Łukasz Stelmach wrote:

quoted

ASIX AX88796[1] is a versatile ethernet adapter chip, that can be
connected to a CPU with a 8/16-bit bus or with an SPI. This driver
supports SPI connection.

...

quoted

quoted

quoted

+++ b/drivers/net/ethernet/asix/Kconfig

@@ -0,0 +1,20 @@
+#
+# Asix network device configuration
+#
+
+config NET_VENDOR_ASIX
+	bool "Asix devices"
+	depends on SPI
+	help
+	  If you have a network (Ethernet) interface based on a chip from ASIX, say Y

Looks like too long, did it pass checkpatch?

Yes? Let me try again. Yes, this one passed, but I missed a few other
problems. Thank you.

quoted

quoted

+
+if NET_VENDOR_ASIX
+
+config SPI_AX88796C
+	tristate "Asix AX88796C-SPI support"
+	depends on SPI
+	depends on GPIOLIB
+	help
+	  Say Y here if you intend to attach a Asix AX88796C as SPI mode
+
+endif # NET_VENDOR_ASIX

There are plenty of other ethernet devices made by ASIX (eg USB ones)
that have nothing at all to do with this driver.
So those questions are too broad.

The first one should probable be for ASIX SPI network devices.

On the other hand there is only one ASIX SPI network device and there
are four other Non-PCI AX88* chips (and that is all I know about them).

(I can't imagine SPI being fast enough to be useful for ethernet...)

Not for a file server, sure. It handles clock up to 40MHz and it's meant
for systems that cannot handle more than a few MB/s anyway.

-- 
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics