Re: [PATCH 1/3] dt-bindings: Add support for Broadcom USB pin map driver
From: Rob Herring <robh@kernel.org>
Date: 2020-08-24 23:30:48
Also in:
linux-arm-kernel, linux-usb, lkml
On Wed, Aug 12, 2020 at 04:20:16PM -0400, Al Cooper wrote:
Add DT bindings for the Broadcom USB pin map driver. This driver allows some USB input and output signals to be mapped to any GPIO instead of the normal dedicated pins to/from the XHCI controller.
Is this a driver or h/w block because bindings are for h/w blocks?
quoted hunk ↗ jump to hunk
Signed-off-by: Al Cooper <alcooperx@gmail.com> --- .../bindings/usb/brcm,usb-pinmap.yaml | 63 +++++++++++++++++++ 1 file changed, 63 insertions(+) create mode 100644 Documentation/devicetree/bindings/usb/brcm,usb-pinmap.yamldiff --git a/Documentation/devicetree/bindings/usb/brcm,usb-pinmap.yaml b/Documentation/devicetree/bindings/usb/brcm,usb-pinmap.yaml new file mode 100644 index 000000000000..19cf6ad36373 --- /dev/null +++ b/Documentation/devicetree/bindings/usb/brcm,usb-pinmap.yaml@@ -0,0 +1,63 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/usb/brcm,usb-pinmap.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Broadcom USB pin map Controller Device Tree Bindings + +maintainers: + - Al Cooper <alcooperx@gmail.com> + +properties: + compatible: + items: + - const: brcm,usb-pinmap
2 space indentation please.
+ + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + description: Must be defined if any out-gpios are specified.
'dependencies' can express this in schema.
+ + in-gpios: + description: Array of one or more GPIO pins used for input signals.
You need to define how many GPIOs are valid.
+ + in-names: + description: Array of input signal names, one per gpio in in-gpios.
No, this isn't how we name GPIOs. The part before '-gpios' is how.
+ + in-masks: + description: Array of enable and mask pairs, one per gpio in-gpios.
Needs a vendor prefix.
+
+ out-gpios:
+ description: Array of one or more GPIO pins used for output signals.
+
+ out-names:
+ description: Array of output signal names, one per gpio in out-gpios.
+
+ out-masks:
+ description: Array of enable, value, changed and clear masks, one
+ per gpio in out-gpios.
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ usb_pinmap: usb-pinmap@22000d0 {
+ compatible = "brcm,usb-pinmap";
+ reg = <0x22000d0 0x4>;
+ in-gpios = <&gpio 18 0>, <&gpio 19 0>;
+ in-names = "VBUS", "PWRFLT";
+ in-masks = <0x8000 0x40000 0x10000 0x80000>;
+ out-gpios = <&gpio 20 0>;
+ out-names = "PWRON";
+ out-masks = <0x20000 0x800000 0x400000 0x200000>;
+ interrupts = <0x0 0xb2 0x4>;
+ };
+
+...
--
2.17.1