Hi Andy,

On 21/8/2020 6:56 pm, Andy Shevchenko wrote:

On Fri, Aug 21, 2020 at 05:32:11PM +0800, Rahul Tanwar wrote:

quoted

Intel Lightning Mountain(LGM) SoC contains a PWM fan controller.
This PWM controller does not have any other consumer, it is a
dedicated PWM controller for fan attached to the system. Add
driver for this PWM fan controller.

...

quoted

+#include <linux/bitfield.h>
+#include <linux/clk.h>
+#include <linux/module.h>
+#include <linux/of_device.h>

We haven't settle this yet...

I investigated more about it. I was getting build error because we were
relying on of_device.h for including platform_device.h. You are right that
we are not using anything from of_device.h. So i removed of_device.h from
driver and added include <linux/platform_device.h> & build is ok.

Regarding mod_devicetable.h header, it gets included indirectly from
<linux/pwm.h> which includes of.h which includes mod_devicetable.h. So i
think no point including it again in the driver.

Regards,
Rahul

quoted

+#include <linux/pwm.h>
+#include <linux/regmap.h>
+#include <linux/reset.h>