Re: [PATCH net-next v2 0/7] net-next: dsa: mt7530: add support for MT7531
From: Landen Chao <hidden>
Date: 2020-08-19 07:45:54
Also in:
linux-mediatek, lkml, netdev
Hi DENG, MT7531 mirror port has been fixed by new definition of register base in header file. The logic of mirror port setting in 7530.c is reused.
@@ -41,6 +42,33 @@ enum mt753x_id { #define MIRROR_PORT(x) ((x) & 0x7) #define MIRROR_MASK 0x7 +/* Registers for CPU forward control */ +#define MT7531_CFC 0x4 +#define MT7531_MIRROR_EN BIT(19) +#define MT7531_MIRROR_MASK (MIRROR_MASK << 16) +#define MT7531_MIRROR_PORT_GET(x) (((x) >> 16) & MIRROR_MASK) +#define MT7531_MIRROR_PORT_SET(x) (((x) & MIRROR_MASK) << 16) +#define MT7531_CPU_PMAP_MASK GENMASK(7, 0) + +#define MT753X_MIRROR_REG(id) (((id) == ID_MT7531) ? \ + MT7531_CFC : MT7530_MFC) +#define MT753X_MIRROR_EN(id) (((id) == ID_MT7531) ? \ + MT7531_MIRROR_EN : MIRROR_EN) +#define MT753X_MIRROR_MASK(id) (((id) == ID_MT7531) ? \ + MT7531_MIRROR_MASK : MIRROR_MASK)
On Wed, 2020-08-19 at 11:49 +0800, DENG Qingfang wrote:
Hi, Is port mirroring working? Port mirroring registers on MT7531 have moved, according to bpi's MT7531 reference manual. Please fix that as well.