Re: [PATCH v4 01/12] ASoC: qcom: Add common array to initialize soc based core clocks

Quoting Rohit Kumar (2020-08-05 20:59:48)

Thanks Stephen for reviewing.

On 8/6/2020 6:01 AM, Stephen Boyd wrote:

quoted

Quoting Rohit kumar (2020-07-22 03:31:44)

quoted

From: Ajit Pandey <redacted>

LPASS variants have their own soc specific clocks that needs to be
enabled for MI2S audio support. Added a common variable in drvdata to
initialize such clocks using bulk clk api. Such clock names is
defined in variants specific data and needs to fetched during init.

Why not just get all the clks and not even care about the names of them?
Use devm_clk_bulk_get_all() for that, unless some clks need to change
rates?

There is ahbix clk which needs clk rate to be set. Please check below 
patch in

the series for reference

[PATCH v5 02/12] ASoC: qcom: lpass-cpu: Move ahbix clk to platform 
specific function

Alright. I wonder if we could make the API better or the binding better
and always have the rate settable clk first and then
devm_clk_bulk_get_all() could be used along with clk_set_rate() on some 
array element 0 or something. Anyway, don't mind me, I'm just thinking
how to make this simpler.