Re: [PATCH 3/4] usb: typec: tcpm: Add support for altmodes
From: Guenter Roeck <linux@roeck-us.net>
Date: 2020-07-15 16:41:08
Also in:
linux-usb
On 7/14/20 4:36 AM, Hans de Goede wrote:
quoted hunk ↗ jump to hunk
Add support for altmodes described in the usb-connector fwnode associated with the Type-C controller by calling the new typec_port_register_altmodes_from_fwnode() helper for this. Signed-off-by: Hans de Goede <redacted> --- drivers/usb/typec/tcpm/tcpm.c | 6 ++++++ 1 file changed, 6 insertions(+)diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c index 82b19ebd7838..b4a66e6bf68c 100644 --- a/drivers/usb/typec/tcpm/tcpm.c +++ b/drivers/usb/typec/tcpm/tcpm.c@@ -4793,6 +4793,12 @@ struct tcpm_port *tcpm_register_port(struct device *dev, struct tcpc_dev *tcpc) goto out_role_sw_put; } + typec_port_register_altmodes_from_fwnode(port->typec_port, + &tcpm_altmode_ops, port, + port->port_altmode, + ALTMODE_DISCOVERY_MAX, + tcpc->fwnode);
As mentioned in the other patch, errors from this function should not be ignored (or there should be a detailed explanation why it is ok to ignore them). Thanks, Guenter
+ mutex_lock(&port->lock); tcpm_init(port); mutex_unlock(&port->lock);