Sebastian

On 7/27/20 5:36 PM, Sebastian Reichel wrote:

Hi,

On Tue, Jul 21, 2020 at 11:32:04AM -0500, Dan Murphy wrote:

quoted

Add the Texas Instruments BQ27561 battery monitor.  The register address
map is laid out the same as compared to other devices within the file.
The battery status register has differing bits to determine if the
battery is full, discharging or dead.

Signed-off-by: Dan Murphy <redacted>
---

Looks mostly good to me, but

[...]

quoted

@@ -1710,6 +1769,13 @@ static int bq27xxx_battery_capacity_level(struct bq27xxx_device_info *di,
  			level = POWER_SUPPLY_CAPACITY_LEVEL_CRITICAL;
  		else
  			level = POWER_SUPPLY_CAPACITY_LEVEL_NORMAL;
+	} else if (di->opts & BQ27561_O_BITS) {
+		if (di->cache.flags & BQ27561_FLAG_FC)
+			level = POWER_SUPPLY_CAPACITY_LEVEL_FULL;
+		else if (di->cache.flags & BQ27561_FLAG_DIS_CH)
+			level = POWER_SUPPLY_CAPACITY_LEVEL_CRITICAL;

Shouldn't this be checking for FLAG_FDC instead of FLAG_DIS_CH?

Yes.

Dan

-- Sebastian