Re: [PATCH v2 7/7] arm64: dts: qcom: sm8250: add interconnect nodes
From: Sibi Sankar <hidden>
Date: 2020-07-24 14:13:21
Also in:
linux-arm-msm, lkml
Hey Jonathan, Thanks for the patch! Please use the suggested register space definitions instead. On 2020-07-13 21:11, Jonathan Marek wrote:
quoted hunk ↗ jump to hunk
Add the interconnect dts nodes for sm8250. Signed-off-by: Jonathan Marek <redacted> --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 82 ++++++++++++++++++++++++++++ 1 file changed, 82 insertions(+)diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsib/arch/arm64/boot/dts/qcom/sm8250.dtsi index 636e2196138c..dfc1b7fa7d85 100644--- a/arch/arm64/boot/dts/qcom/sm8250.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi@@ -11,6 +11,7 @@ #include <dt-bindings/power/qcom-aoss-qmp.h> #include <dt-bindings/power/qcom-rpmpd.h> #include <dt-bindings/soc/qcom,rpmh-rsc.h> +#include <dt-bindings/interconnect/qcom,sm8250.h>
please fix ^^ sort order
quoted hunk ↗ jump to hunk
/ { interrupt-parent = <&intc>;@@ -978,6 +979,55 @@ spi13: spi@a94000 { }; }; + config_noc: interconnect@1500000 { + compatible = "qcom,sm8250-config-noc"; + reg = <0 0x01500000 0 0x1000>;
0x01500000 0xa580
+ #interconnect-cells = <1>;
+ qcom,bcm-voters = <&apps_bcm_voter>;
+ };
+
+ ipa_virt: interconnect@1620000 {
+ compatible = "qcom,sm8250-ipa-virt";
+ reg = <0 0x01620000 0 0x1000>;0x01e00000 0x1000
+ #interconnect-cells = <1>;
+ qcom,bcm-voters = <&apps_bcm_voter>;
+ };
+
+ system_noc: interconnect@1632000 {
+ compatible = "qcom,sm8250-system-noc";
+ reg = <0 0x01632000 0 0x1000>;0x01620000 0x1C200
+ #interconnect-cells = <1>;
+ qcom,bcm-voters = <&apps_bcm_voter>;
+ };
+
+ aggre1_noc: interconnect@16e2000 {
+ compatible = "qcom,sm8250-aggre1-noc";
+ reg = <0 0x016e2000 0 0x1000>;0x016e0000 0x1f180
+ #interconnect-cells = <1>;
+ qcom,bcm-voters = <&apps_bcm_voter>;
+ };
+
+ aggre2_noc: interconnect@1703000 {
+ compatible = "qcom,sm8250-aggre2-noc";
+ reg = <0 0x01703000 0 0x1000>;0x01700000 0x33000
+ #interconnect-cells = <1>;
+ qcom,bcm-voters = <&apps_bcm_voter>;
+ };
+
+ compute_noc: interconnect@1733000 {
+ compatible = "qcom,sm8250-compute-noc";
+ reg = <0 0x01733000 0 0x1000>;0x01733000 0xd180
+ #interconnect-cells = <1>;
+ qcom,bcm-voters = <&apps_bcm_voter>;
+ };
+
+ mmss_noc: interconnect@174a000 {
+ compatible = "qcom,sm8250-mmss-noc";
+ reg = <0 0x0174a000 0 0x1000>;0x01740000 0x1f080
quoted hunk ↗ jump to hunk
+ #interconnect-cells = <1>; + qcom,bcm-voters = <&apps_bcm_voter>; + }; + ufs_mem_hc: ufshc@1d84000 { compatible = "qcom,sm8250-ufshc", "qcom,ufshc", "jedec,ufs-2.0";@@ -1364,6 +1414,34 @@ usb_2_ssphy: lane@88eb200 { }; }; + dc_noc: interconnect@90c0000 { + compatible = "qcom,sm8250-dc-noc"; + reg = <0 0x090c0000 0 0x1000>;
0x090c0000 0x4200
+ #interconnect-cells = <1>;
+ qcom,bcm-voters = <&apps_bcm_voter>;
+ };
+
+ mc_virt: interconnect@9100000 {
+ compatible = "qcom,sm8250-mc-virt";
+ reg = <0 0x09100000 0 0x1000>;0x0163d000 0x1000
+ #interconnect-cells = <1>;
+ qcom,bcm-voters = <&apps_bcm_voter>;
+ };
+
+ gem_noc: interconnect@9121000 {
+ compatible = "qcom,sm8250-gem-noc";
+ reg = <0 0x09121000 0 0x1000>;0x09100000 0xb4000
+ #interconnect-cells = <1>;
+ qcom,bcm-voters = <&apps_bcm_voter>;
+ };
+
+ npu_noc: interconnect@9990000 {
+ compatible = "qcom,sm8250-npu-noc";
+ reg = <0 0x09990000 0 0x1000>;0x09990000 0x1600
quoted hunk ↗ jump to hunk
+ #interconnect-cells = <1>; + qcom,bcm-voters = <&apps_bcm_voter>; + }; + usb_1: usb@a6f8800 { compatible = "qcom,sm8250-dwc3", "qcom,dwc3"; reg = <0 0x0a6f8800 0 0x400>;@@ -2359,6 +2437,10 @@ rpmhpd_opp_turbo_l1: opp10 { }; }; }; + + apps_bcm_voter: bcm_voter { + compatible = "qcom,bcm-voter"; + }; }; };
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.