Re: [PATCH v3 02/16] dt-bindings: media: mtk-vcodec: document SCP node
From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Date: 2020-07-22 21:37:59
Also in:
linux-media, linux-mediatek, lkml
On Mon, 13 Jul 2020 at 03:09, Alexandre Courbot [off-list ref] wrote:
quoted hunk ↗ jump to hunk
The mediatek codecs can use either the VPU or the SCP as their interface to firmware. Reflect this in the DT bindings. Signed-off-by: Alexandre Courbot <redacted> Acked-by: Tiffany Lin <tiffany.lin@mediatek.com> --- Documentation/devicetree/bindings/media/mediatek-vcodec.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)diff --git a/Documentation/devicetree/bindings/media/mediatek-vcodec.txt b/Documentation/devicetree/bindings/media/mediatek-vcodec.txt index b6b5dde6abd8..7aef0a4fe207 100644 --- a/Documentation/devicetree/bindings/media/mediatek-vcodec.txt +++ b/Documentation/devicetree/bindings/media/mediatek-vcodec.txt@@ -19,7 +19,9 @@ Required properties: - iommus : should point to the respective IOMMU block with master port as argument, see Documentation/devicetree/bindings/iommu/mediatek,iommu.txt for details. -- mediatek,vpu : the node of video processor unit +One of the two following nodes: +- mediatek,vpu : the node of the video processor unit, if using VPU. +- mediatek,scp : the noode of the SCP unit, if using SCP.
This interface doesn't enforce the fact only one of the two should be present, but not both (which is the case, right?). I hope I'm not bikeshedding here, but from an interface POV, would it be cleaner to just have a single mediatek,coprocessor property, and then use of_device_is_compatible to distinguish VPU from SCP type? Moreover, I'd argue you don't need a dt-binding change and should just keep the current mediatek-vpu property, and then rely on of_device_is_compatible. Regards, Ezequiel
Example: -- 2.27.0.383.g050319c2ae-goog