Re: [PATCH 6/9] phy: qcom-qmp: Add compatible for ipq8074 pcie gen3 qmp phy
From: Vinod Koul <vkoul@kernel.org>
Date: 2020-07-13 06:04:33
Also in:
linux-arm-msm, linux-clk, linux-pci, lkml
On 05-07-20, 14:47, Sivaprakash Murugesan wrote:
quoted hunk ↗ jump to hunk
ipq8074 has two pcie ports, one gen2 and one gen3 ports. with phy support already available for gen2 pcie ports add support for pcie gen3 port phy. Co-developed-by: Selvam Sathappan Periakaruppan <redacted> Signed-off-by: Selvam Sathappan Periakaruppan <redacted> Signed-off-by: Sivaprakash Murugesan <redacted> --- drivers/phy/qualcomm/phy-qcom-pcie3-qmp.h | 137 ++++++++++++++++++++++++ drivers/phy/qualcomm/phy-qcom-qmp.c | 172 +++++++++++++++++++++++++++++- 2 files changed, 307 insertions(+), 2 deletions(-) create mode 100644 drivers/phy/qualcomm/phy-qcom-pcie3-qmp.hdiff --git a/drivers/phy/qualcomm/phy-qcom-pcie3-qmp.h b/drivers/phy/qualcomm/phy-qcom-pcie3-qmp.h new file mode 100644 index 000000000000..bb567673d9b5 --- /dev/null +++ b/drivers/phy/qualcomm/phy-qcom-pcie3-qmp.h@@ -0,0 +1,137 @@ +/* SPDX-License-Identifier: GPL-2.0*
Trailing * at the end, it would make sense to split the spdx and copyright parts to two single lines
quoted hunk ↗ jump to hunk
@@ -2550,8 +2707,16 @@ static int phy_pipe_clk_register(struct qcom_qmp *qmp, struct device_node *np) init.ops = &clk_fixed_rate_ops; - /* controllers using QMP phys use 125MHz pipe clock interface */ - fixed->fixed_rate = 125000000; + /* + * controllers using QMP phys use 125MHz pipe clock interface unless + * other frequency is specified in dts + */ + ret = of_property_read_u32(np, "clock-output-rate", + (u32 *)&fixed->fixed_rate);
is this cast required?
+ if (ret) + fixed->fixed_rate = 125000000; + + dev_info(qmp->dev, "fixed freq %lu\n", fixed->fixed_rate);
debug? -- ~Vinod