Re: [PATCH v10 07/20] dt-bindings: mtd: Document boolean NAND ECC properties
From: Rob Herring <robh@kernel.org>
Date: 2020-06-04 23:08:10
Also in:
linux-arm-kernel
On Wed, Jun 03, 2020 at 07:57:46PM +0200, Miquel Raynal wrote:
quoted hunk ↗ jump to hunk
Document nand-use-soft-ecc-engine and nand-no-ecc-engine properties. The former is here to force software correction, the latter prevents any correction to happen. These properties (along with nand-ecc-engine) are supposed to be more accurate than the current nand-ecc-modes wich is very misleading and very often people think it is mandatory while the core should be relied upon to decide which correction to handle. nand-ecc-mode was already inacurate, but it becomes totally problematic with setups where there are several hardware engines. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- Documentation/devicetree/bindings/mtd/nand-controller.yaml | 6 ++++++ 1 file changed, 6 insertions(+)diff --git a/Documentation/devicetree/bindings/mtd/nand-controller.yaml b/Documentation/devicetree/bindings/mtd/nand-controller.yaml index 0969d2e6720b..a3750978ebb8 100644 --- a/Documentation/devicetree/bindings/mtd/nand-controller.yaml +++ b/Documentation/devicetree/bindings/mtd/nand-controller.yaml@@ -68,6 +68,12 @@ patternProperties: 3/ The ECC engine is external, in this case the phandle should reference the specific ECC engine node. + nand-use-soft-ecc-engine: true + description: Use a software ECC engine.
Humm, I'm surprised this is valid YAML. nand-use-soft-ecc-engine can't be both a boolean and a map (aka schema, aka dict). nand-use-soft-ecc-engine: type: boolean description: ...
+
+ nand-no-ecc-engine: true
+ description: Do not use any ECC correction.
+
nand-ecc-placement:
allOf:
- $ref: /schemas/types.yaml#/definitions/string
--
2.20.1