Hi,

On Mon, Jun 29, 2020 at 5:14 AM Rakesh Pillai [off-list ref] wrote:

quoted

-----Original Message-----
From: Doug Anderson <dianders@chromium.org>
Sent: Saturday, June 27, 2020 3:22 AM
To: Rakesh Pillai <redacted>; Kalle Valo
[off-list ref]
Cc: ath10k@lists.infradead.org; open list:OPEN FIRMWARE AND FLATTENED
DEVICE TREE BINDINGS [off-list ref]; linux-wireless <linux-
wireless@vger.kernel.org>; LKML [off-list ref]
Subject: Re: [PATCH 2/2] ath10k: Add support for chain1 regulator supply
voting

Hi,

On Fri, Jun 26, 2020 at 11:02 AM Rakesh Pillai [off-list ref] wrote:

quoted

Add support to vote for chain-1 voltage regulator
in WCN3990.

Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1

Signed-off-by: Rakesh Pillai <redacted>
---
 drivers/net/wireless/ath/ath10k/snoc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/ath/ath10k/snoc.c

b/drivers/net/wireless/ath/ath10k/snoc.c

quoted

index 645ed5f..407a074 100644

--- a/drivers/net/wireless/ath/ath10k/snoc.c
+++ b/drivers/net/wireless/ath/ath10k/snoc.c

@@ -45,6 +45,7 @@ static const char * const ath10k_regulators[] = {
        "vdd-1.8-xo",
        "vdd-1.3-rfa",
        "vdd-3.3-ch0",
+       "vdd-3.3-ch1",

Reviewed-by: Douglas Anderson <dianders@chromium.org>

...with the slight nit that ${SUBJECT} and description should probably
call it "chan1" and not "chain1".  Presumably the maintainer can fix
when applying.

-Doug

Hi Doug,

It has to be chain1 only, not chan1.
This is the power supply rail for the wlan-chain1

Whoa, really?  "ch1" stands for "chain1", not "chan1"?  That is
seriously weird (at least to me), but I find at least one document
that agrees with you.  Sorry for the mistake!

-Doug