Re: [PATCH 4/4] ARM: dts: uniphier: change support card to simple-mfd from simple-bus
From: Lee Jones <hidden>
Date: 2020-06-23 12:24:20
Also in:
lkml
On Tue, 23 Jun 2020, Masahiro Yamada wrote:
'make ARCH=arm dtbs_check' emits the following warning: support-card@1,1f00000: $nodename:0: 'support-card@1,1f00000' does not match '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$' Maybe, simple-mfd could be a better fit for this device.
The two should be equivalent. What do you mean by "maybe"? Does this squash the warning? Isn't the issue caused by the ','?
quoted hunk ↗ jump to hunk
Signed-off-by: Masahiro Yamada <redacted> --- arch/arm/boot/dts/uniphier-support-card.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/arch/arm/boot/dts/uniphier-support-card.dtsi b/arch/arm/boot/dts/uniphier-support-card.dtsi index 11e46e7de7c5..eedc10cbc6e6 100644 --- a/arch/arm/boot/dts/uniphier-support-card.dtsi +++ b/arch/arm/boot/dts/uniphier-support-card.dtsi@@ -10,7 +10,7 @@ &system_bus { ranges = <1 0x00000000 0x42000000 0x02000000>; support_card: support-card@1,1f00000 { - compatible = "simple-bus"; + compatible = "simple-mfd"; #address-cells = <1>; #size-cells = <1>; ranges = <0x00000000 1 0x01f00000 0x00100000>;
-- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog