Re: [PATCH v11 3/8] tpm: tpm_tis: Add retry in case of protocol failure or... | linux-devicetree

[PATCH v11 0/8] Add tpm i2c ptp driver · <hidden> · 2020-06-18
[PATCH v11 4/8] tpm: tpm_tis: Rewrite "tpm_tis_req_canceled()" · <hidden> · 2020-06-18
[PATCH v11 7/8] tpm: Add YAML schema for TPM TIS I2C options · <hidden> · 2020-06-18
[PATCH v11 1/8] tpm: Make read{16, 32}() and write32() in tpm_tis_phy_ops optional · <hidden> · 2020-06-18
[PATCH v11 5/8] tpm: Handle an exception for TPM Firmware Update mode. · <hidden> · 2020-06-18
[PATCH v11 2/8] tpm: tpm_tis: Fix expected bit handling and send all bytes in one shot without last byte in exception · <hidden> · 2020-06-18
Re: [PATCH v11 2/8] tpm: tpm_tis: Fix expected bit handling and send all bytes in one shot without last byte in exception · Jarkko Sakkinen <hidden> · 2020-06-22
[PATCH v11 8/8] tpm: tpm_tis: add tpm_tis_i2c driver · <hidden> · 2020-06-18
[PATCH v11 6/8] tpm: tpm_tis: verify TPM_STS register is valid after locality request · <hidden> · 2020-06-18
[PATCH v11 3/8] tpm: tpm_tis: Add retry in case of protocol failure or data integrity (on I2C only) failure. · <hidden> · 2020-06-18
Re: [PATCH v11 3/8] tpm: tpm_tis: Add retry in case of protocol failure or data integrity (on I2C only) failure. · Jarkko Sakkinen <hidden> · 2020-06-22
Re: [PATCH v11 3/8] tpm: tpm_tis: Add retry in case of protocol failure or data integrity (on I2C only) failure. · Jarkko Sakkinen <hidden> · 2020-06-22
Re: [PATCH v11 0/8] Add tpm i2c ptp driver · Jarkko Sakkinen <hidden> · 2020-06-22

Re: [PATCH v11 3/8] tpm: tpm_tis: Add retry in case of protocol failure or data integrity (on I2C only) failure.

From: Jarkko Sakkinen <hidden>
Date: 2020-06-22 21:59:36
Also in: linux-integrity, lkml

On Thu, Jun 18, 2020 at 04:43:38PM +0300, amirmizi6@gmail.com wrote:

From: Amir Mizinski <redacted>

Added a retry mechanism on any protocol error. In addition, a retry is
added in case of a data integrity issue in the I2C bus protocol. The check
is performed after sending a command to the TPM and after receiving a
response from the TPM.

No chance to merge this without reasoning why on any protocol error we
should retry. It's not reasoned here. Unfotunately, with this premise I
cannot merge this.

/Jarkko

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help