Thread (11 messages) 11 messages, 3 authors, 2020-06-25

Re: [PATCH v2 2/2] Add PWM fan controller driver for LGM SoC

From: Uwe Kleine-König <hidden>
Date: 2020-06-19 06:29:21
Also in: linux-pwm, lkml

Hello again,

On Fri, Jun 19, 2020 at 08:02:13AM +0200, Uwe Kleine-König wrote:
You had concerns about my review feedback that I don't like the fan
stuff in the PWM driver. I still think that the fan part doesn't belong
here.
I suggest splitting the patch. First introduce a generic PWM driver and
in a second patch add the fan stuff. This way you can get an ack from me
at least for a part. Also it makes it more obvious that there is going
on something special and we can have a dedicated discussion about it and
a concious decision made at the end.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help