Thread (5 messages) 5 messages, 4 authors, 2020-06-26

Re: [v3] drm/bridge: ti-sn65dsi86: ensure bridge suspend happens during PM sleep

From: Doug Anderson <dianders@chromium.org>
Date: 2020-06-18 22:09:34
Also in: dri-devel, linux-arm-msm, lkml

Hi,

On Tue, Jun 9, 2020 at 5:05 AM Harigovindan P [off-list ref] wrote:
ti-sn65dsi86 bridge is enumerated as a runtime device. When
suspend is triggered, PM core adds a refcount on all the
devices and calls device suspend, since usage count is
already incremented, runtime suspend will not be called
and it kept the bridge regulators and gpios ON which resulted
in platform not entering into XO shutdown.

Add changes to force suspend on the runtime device during pm sleep.

Signed-off-by: Harigovindan P <redacted>
---

Changes in v2:
        - Include bridge name in the commit message and
        remove dependent patchwork link from the commit
        text as bridge is independent of OEM(Stephen Boyd)

Changes in v3:
        - Updating changelog to explain the need for patch

 drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 ++
 1 file changed, 2 insertions(+)
I think this patch is good to go now (has both Stephen's and my
reviews).  I noticed that Neil landed my other patches to this driver
recently (thanks!) and wondered why he didn't land this one.  Then, I
realized that you didn't send it to him or the other bridge
maintainer.  :(  Have you tried running get_maintainer?

$ ./scripts/get_maintainer.pl -f drivers/gpu/drm/bridge/ti-sn65dsi86.c
Andrzej Hajda [off-list ref] (maintainer:DRM DRIVERS FOR BRIDGE CHIPS)
Neil Armstrong [off-list ref] (maintainer:DRM DRIVERS FOR
BRIDGE CHIPS)
Laurent Pinchart [off-list ref] (reviewer:DRM
DRIVERS FOR BRIDGE CHIPS)
Jonas Karlman [off-list ref] (reviewer:DRM DRIVERS FOR BRIDGE CHIPS)
Jernej Skrabec [off-list ref] (reviewer:DRM DRIVERS FOR BRIDGE CHIPS)
David Airlie [off-list ref] (maintainer:DRM DRIVERS)
Daniel Vetter [off-list ref] (maintainer:DRM DRIVERS)
dri-devel@lists.freedesktop.org (open list:DRM DRIVERS)
linux-kernel@vger.kernel.org (open list)

In any case, unless someone has extra feedback on this patch I think
it's ready to land.

Neil: If you're willing to land this patch too, can you let
Harigovindan know if it needs to be re-sent with you in the "To:" list
or if you can find it on the dri-devel list?

Thanks!

-Doug
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help