Re: [PATCH v9 05/11] dt-bindings: display: add i.MX6 MIPI DSI host controller doc
From: Rob Herring <robh@kernel.org>
Date: 2020-06-12 21:11:08
Also in:
dri-devel, linux-arm-kernel, linux-rockchip, lkml
On Tue, Jun 09, 2020 at 08:49:53PM +0300, Adrian Ratiu wrote:
This provides an example DT binding for the MIPI DSI host controller
It's not an example. It defines the exact binding for this peripheral.
quoted hunk ↗ jump to hunk
present on the i.MX6 SoC based on Synopsis DesignWare v1.01 IP. Cc: Rob Herring <robh@kernel.org> Cc: Neil Armstrong <redacted> Cc: Fabio Estevam <festevam@gmail.com> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: devicetree@vger.kernel.org Tested-by: Adrian Pop <redacted> Tested-by: Arnaud Ferraris <redacted> Signed-off-by: Sjoerd Simons <redacted> Signed-off-by: Martyn Welch <redacted> Signed-off-by: Adrian Ratiu <redacted> --- Changes since v8: - Fixed small compatible string typo caught by checkpatch - Added custom select for 'fsl,imx6-mipi-dsi' (Rob) - Replaced additionalProperties -> unevaluatedProperties (Rob) - Dropped all nodes not adding any new constraints apart from the recently upstreamed snps,dw-mipi-dsi.yaml (Rob) Changes since v7: - Clarified port@0,1 descriptions, marked them as required and added missing port@0 in example (Laurent) Changes since v6: - Added ref to the newly created snps,dw-mipi-dsi.yaml (Laurent) - Moved *-cells properties outside patternProperties (Laurent) - Removed the panel port documentation (Laurent) - Wrapped lines at 80 chars, typo fixes, sort includes (Laurent) Changes since v5: - Fixed missing reg warning (Fabio) - Updated dt-schema and fixed warnings (Rob) Changes since v4: - Fixed yaml binding to pass `make dt_binding_check dtbs_check` and addressed received binding feedback (Rob) Changes since v3: - Added commit message (Neil) - Converted to yaml format (Neil) - Minor dt node + driver fixes (Rob) - Added small panel example to the host controller binding Changes since v2: - Fixed commit tags (Emil) --- .../display/imx/fsl,mipi-dsi-imx6.yaml | 112 ++++++++++++++++++ 1 file changed, 112 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yamldiff --git a/Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml b/Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml new file mode 100644 index 0000000000000..86093729fd5f9 --- /dev/null +++ b/Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml@@ -0,0 +1,112 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/imx/fsl,mipi-dsi-imx6.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Freescale i.MX6 DW MIPI DSI Host Controller + +maintainers: + - Adrian Ratiu <adrian.ratiu@collabora.com> + +description: | + The i.MX6 DSI host controller is a Synopsys DesignWare MIPI DSI v1.01 + IP block with a companion PHY IP. + + These DT bindings follow the Synopsys DW MIPI DSI bindings defined in + Documentation/devicetree/bindings/display/bridge/dw_mipi_dsi.txt with + the following device-specific properties. + +allOf: + - $ref: ../bridge/snps,dw-mipi-dsi.yaml# + +# Need a custom select here or 'snps,dw-mipi-dsi' will match lots of nodes +select: + properties: + compatible: + contains: + enum: + - fsl,imx6-mipi-dsi + required: + - compatible + +properties:
+ '#address-cells': + const: 1 + + '#size-cells': + const: 0
These 2 are covered by dsi-controller.yaml, so you can drop them. Otherwise, Reviewed-by: Rob Herring <robh@kernel.org>