Re: [PATCH 1/2] clk: qcom: gcc: Add genpd active wakeup flag for sc7180
From: Stephen Boyd <sboyd@kernel.org>
Date: 2020-06-11 22:47:02
Also in:
linux-arm-msm, linux-clk, linux-usb, lkml
Quoting Sandeep Maheswaram (2020-06-11 07:28:02)
From: Taniya Das <redacted> The USB client requires the usb30_prim gdsc to be kept active for certain use cases, thus add the GENPD_FLAG_ACTIVE_WAKEUP flag.
Can you please describe more of what this is for? Once sentence doesn't tell me much at all. I guess that sometimes we want to wakeup from USB and so the usb gdsc should be marked as "maybe keep on for wakeups" with the GENPD_FLAG_ACTIVE_WAKEUP flag if the USB controller is wakeup enabled?
Signed-off-by: Taniya Das <redacted> ---
Add a Fixes: tag too? And I assume we need to do this for all USB gdscs on various SoCs and maybe other GDSCs like PCIe. Any plans to fix those GDSCs?
quoted hunk ↗ jump to hunk
drivers/clk/qcom/gcc-sc7180.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/clk/qcom/gcc-sc7180.c b/drivers/clk/qcom/gcc-sc7180.c index ca4383e..2b3dd4e 100644 --- a/drivers/clk/qcom/gcc-sc7180.c +++ b/drivers/clk/qcom/gcc-sc7180.c@@ -2263,6 +2263,7 @@ static struct gdsc usb30_prim_gdsc = { .gdscr = 0x0f004, .pd = { .name = "usb30_prim_gdsc", + .flags = GENPD_FLAG_ACTIVE_WAKEUP, }, .pwrsts = PWRSTS_OFF_ON, };