Thread (7 messages) read the whole thread 7 messages, 2 authors, 2020-06-04

Re: [Freedreno] [PATCH v7 6/6] arm6: dts: qcom: sm845: Set the compatible string for the GPU SMMU

From: Jordan Crouse <hidden>
Date: 2020-06-04 22:02:27
Also in: linux-arm-msm, lkml

On Thu, Jun 04, 2020 at 02:27:21PM -0700, Rob Clark wrote:
On Thu, Jun 4, 2020 at 1:57 PM Jordan Crouse [off-list ref] wrote:
quoted
Set the qcom,adreno-smmu compatible string for the GPU SMMU to enable
split pagetables.

Signed-off-by: Jordan Crouse <redacted>
---

 arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 8eb5a31346d2..8b15cd74e9ba 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -3556,7 +3556,7 @@
                };

                adreno_smmu: iommu@5040000 {
-                       compatible = "qcom,sdm845-smmu-v2", "qcom,smmu-v2";
+                       compatible = "qcom,adreno-smmu", "qcom,smmu-v2";
Should this be something like:

   compatible = "qcom,adreno-smmu", "qcom,sdm845-smmu-v2", "qcom,smmu-v2";

so that new dtb still works with old kernel?
As far as I know qcom,sdm845-smmu-v2 never was actually used unless we were
doing the parsing trick somewhere.

Jordan
quoted
                        reg = <0 0x5040000 0 0x10000>;
                        #iommu-cells = <1>;
                        #global-interrupts = <2>;
--
2.17.1

_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help