Re: [PATCH v7 16/20] mtd: nand: Convert generic NAND bits to use the ECC framework
From: Miquel Raynal <miquel.raynal@bootlin.com>
Date: 2020-05-29 09:25:23
Also in:
linux-arm-kernel
Boris Brezillon [off-list ref] wrote on Fri, 29 May 2020 10:32:22 +0200:
On Fri, 29 May 2020 02:25:13 +0200 Miquel Raynal [off-list ref] wrote:quoted
Embed a generic NAND ECC high-level object in the nand_device structure to carry all the ECC engine configuration/data. Adapt the raw NAND and SPI-NAND cores to fit the change.In order to split that one, and make future re-organizations less painful (hope we won't have to do that again, but who knows), I would recommend doing things in this order: 1/ create a nanddev_get_ecc_requirements() helper that returns a const struct nand_ecc_props * 2/ patch spinand to use this helper 3/ introduce nand_ecc 4/ patch rawnand to use the new ecc layer
Sounds like a lot of efforts for a mechanical change to me. Not mentioning that the diff is pretty small now. But ok, I'll try.
quoted
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- drivers/mtd/nand/raw/atmel/nand-controller.c | 9 +++-- drivers/mtd/nand/raw/brcmnand/brcmnand.c | 7 ++-- drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 12 +++--- drivers/mtd/nand/raw/marvell_nand.c | 7 ++-- drivers/mtd/nand/raw/mtk_nand.c | 4 +- drivers/mtd/nand/raw/nand_base.c | 25 ++++++------ drivers/mtd/nand/raw/nand_esmt.c | 11 +++--- drivers/mtd/nand/raw/nand_hynix.c | 41 ++++++++++---------- drivers/mtd/nand/raw/nand_jedec.c | 4 +- drivers/mtd/nand/raw/nand_micron.c | 14 ++++--- drivers/mtd/nand/raw/nand_onfi.c | 8 ++-- drivers/mtd/nand/raw/nand_samsung.c | 19 ++++----- drivers/mtd/nand/raw/nand_toshiba.c | 11 +++--- drivers/mtd/nand/raw/sunxi_nand.c | 5 ++- drivers/mtd/nand/raw/tegra_nand.c | 9 +++-- drivers/mtd/nand/spi/core.c | 8 ++-- drivers/mtd/nand/spi/macronix.c | 6 +-- drivers/mtd/nand/spi/toshiba.c | 6 +-- include/linux/mtd/nand.h | 8 ++-- 19 files changed, 114 insertions(+), 100 deletions(-)