Re: [RESEND v5 12/21] mtd: rawnand: Deprecate nand-ecc-mode in favor of nand-ecc-provider
From: Boris Brezillon <boris.brezillon@collabora.com>
Date: 2020-05-26 23:03:30
On Tue, 26 May 2020 21:56:24 +0200 Miquel Raynal [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Use nand-ecc-provider as the provider DT property. Fallback to nand-ecc-mode if the property does not exist. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- drivers/mtd/nand/raw/nand_base.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c index 69c1b7ab938e..7d17d52cdd34 100644 --- a/drivers/mtd/nand/raw/nand_base.c +++ b/drivers/mtd/nand/raw/nand_base.c@@ -5036,7 +5036,9 @@ of_get_nand_ecc_engine_type(struct device_node *np) const char *pm; int err; - err = of_property_read_string(np, "nand-ecc-mode", &pm); + err = of_property_read_string(np, "nand-ecc-provider", &pm);
"nand-ecc-engine-type" And I'd prefer to have a different string table for that one, so we get rid of the confusing "hw" type (which is actually "on-controller").
+ if (err) + err = of_property_read_string(np, "nand-ecc-mode", &pm); if (err) return NAND_ECC_ENGINE_INVALID;