Re: [PATCH v5 2/6] pinctrl: mediatek: update pinmux definitions for mt6779

On Thu, 2020-04-02 at 14:54 -0700, Sean Wang wrote:

Hi, Hanks

Just a few nitpicks and then Acked-by: Sean Wang [off-list ref]

On Wed, Mar 25, 2020 at 2:31 AM Hanks Chen [off-list ref] wrote:

quoted

Add devicetree bindings for Mediatek mt6779 SoC Pin Controller.

Signed-off-by: Hanks Chen <redacted>
Signed-off-by: Mars Cheng <redacted>
Signed-off-by: Andy Teng <redacted>
---
 include/dt-bindings/pinctrl/mt6779-pinfunc.h | 1242 ++++++++++++++++++++++++++
 1 file changed, 1242 insertions(+)
 create mode 100644 include/dt-bindings/pinctrl/mt6779-pinfunc.h

diff --git a/include/dt-bindings/pinctrl/mt6779-pinfunc.h b/include/dt-bindings/pinctrl/mt6779-pinfunc.h
new file mode 100644
index 0000000..4698d2f
--- /dev/null
+++ b/include/dt-bindings/pinctrl/mt6779-pinfunc.h

@@ -0,0 +1,1242 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (C) 2019 MediaTek Inc.
+ * Author: Andy Teng <andy.teng@mediatek.com>
+ *
+ */
+
+#ifndef __MT6779_PINFUNC_H
+#define __MT6779_PINFUNC_H
+
+#include "mt65xx.h"

Use the standard include path instead:  #include <dt-bindings/pinctrl/mt65xx.h>

Got it, I'll revise it in next version
Thanks for your comment.

quoted

+

<snip>

quoted

+
+#define PINMUX_GPIO209__FUNC_GPIO209 (MTK_PIN_NO(209) | 0)
+
+#endif /* __MT6779-PINFUNC_H */

                   __MT6779_PINFUNC_H

quoted

--
1.7.9.5