Re: [PATCH v2 06/19] spi: dw: Discard static DW DMA slave structures

On Mon, May 18, 2020 at 3:32 PM Serge Semin
[off-list ref] wrote:

On Mon, May 18, 2020 at 02:38:13PM +0300, Andy Shevchenko wrote:

quoted

On Mon, May 18, 2020 at 2:01 PM Andy Shevchenko
[off-list ref] wrote:

quoted

On Sat, May 16, 2020 at 05:20:30PM +0300, Serge Semin wrote:

...

quoted

quoted

I'm not talking about stack, it's fine for me, what I'm talking about is *how*
they are being initialized. Read my message again carefully, please.

And to avoid additional churn around this, the purpose is to show what
Dreq number is in use actually for these transfers (that's why 0
assignment is explicitly there and no counterpart Dreq filled).

Sorry, but nothing persuasive so far. We still can remove their static definition
and explicitly assign zero or one to the src and dst request IDs on stack. I'll do
this in v3, since I have to send one anyway.

Right, I'm completely fine with it, thanks!

-- 
With Best Regards,
Andy Shevchenko