Re: [PATCHv8 0/6] n_gsm serdev support and GNSS driver for droid4
From: Tony Lindgren <tony@atomide.com>
Date: 2020-05-14 17:31:50
Also in:
linux-omap, linux-serial, lkml
* Pavel Machek [off-list ref] [200513 19:10]:
Hi!quoted
Here's the updated set of these patches fixed up for Johan's and Pavel's earlier comments. This series does the following: 1. Adds functions to n_gsm.c for serdev-ngsm.c driver to use 2. Adds a generic serdev-ngsm.c driver that brings up the TS 27.010 TTY ports configured in devicetree with help of n_gsm.c 3. Allows the use of standard Linux device drivers for dedicated TS 27.010 channels for devices like GNSS and ALSA found on some modems for examplequoted
4. Adds a gnss-motmdm consumer driver for the GNSS device found on the Motorola Mapphone MDM6600 modem on devices like droid4It does one thing ... it turns Droid 4 into useful phone!
Right, a minor detail I forgot :)
Thanks a lot. I believe these are same patches as in droid4-pending-v5.7 branch, so whole series is Tested-by: Pavel Machek <redacted> Getting this into 5.8 would be nice :-).quoted
Now without the chardev support, the /dev/gsmtty* using apps need to use "U1234AT+CFUN?" format for the packets. The advantage is less kernel code, and we keep the existing /dev/gsmtty* interface. If we still really need the custom chardev support, that can now be added as needed with the channel specific consumer driver(s), but looks like this won't be needed based on Pavel's ofono work.These work for me, and I have patched ofono with basic functionality. It is no longer possible to use minicom for debugging, but printf can be used instead, so that's not much of a problem. I have adjusted ofono code, and moved away from normal AT support code. More API changes would not be welcome :-).
There is no need for a new API or API changes as we now use the existing n_gsm tty interface for /dev/gsmtty* devices that have been around for years. Regards, Tony