Re: [PATCH 1/2] dt-bindings: chrome: Add cros-ec-typec mux props
From: Rob Herring <robh@kernel.org>
Date: 2020-05-11 19:28:05
Also in:
lkml
On Wed, Apr 22, 2020 at 03:22:39PM -0700, Prashant Malani wrote:
quoted hunk ↗ jump to hunk
Add properties for mode, orientation and USB data role switches for Type C connectors. When available, these will allow the Type C connector class port driver to configure the various switches according to USB PD information (like orientation, alt mode etc.) provided by the Chrome OS EC controller. Signed-off-by: Prashant Malani <redacted> --- .../bindings/chrome/google,cros-ec-typec.yaml | 27 ++++++++++++++++++- 1 file changed, 26 insertions(+), 1 deletion(-)diff --git a/Documentation/devicetree/bindings/chrome/google,cros-ec-typec.yaml b/Documentation/devicetree/bindings/chrome/google,cros-ec-typec.yaml index 6d7396ab8bee..b5814640aa32 100644 --- a/Documentation/devicetree/bindings/chrome/google,cros-ec-typec.yaml +++ b/Documentation/devicetree/bindings/chrome/google,cros-ec-typec.yaml@@ -21,7 +21,21 @@ properties: const: google,cros-ec-typec connector: - $ref: /schemas/connector/usb-connector.yaml# + allOf: + - $ref: /schemas/connector/usb-connector.yaml# + - type: object + properties:
These don't seem CrOS EC specific, so why document them as such.
+ mode-switch: + description: Reference to a DT node for the USB Type C Multiplexer + controlling the data lines routing for this connector.
This is for alternate mode muxing I presume. We already have a mux-control binding. Why not use that here?
+ + orientation-switch: + description: Reference to a DT node for the USB Type C orientation + switch for this connector.
What's in this node?
quoted hunk ↗ jump to hunk
+ + usb-role-switch: + description: Reference to a DT node for the USB Data role switch + for this connector. required: - compatible@@ -49,6 +63,17 @@ examples: data-role = "dual"; try-power-role = "source"; }; + + connector@1 { + compatible = "usb-c-connector"; + reg = <1>; + power-role = "dual"; + data-role = "host"; + try-power-role = "source"; + mode-switch = <&typec_mux>; + orientation-switch = <&typec_orientation_switch>; + usb-role-switch = <&typec_mux>; + }; }; }; };-- 2.26.1.301.g55bc3eb7cb9-goog