Thread (26 messages) 26 messages, 2 authors, 2020-03-12

Re: [PATCH v13 04/21] media: v4l2-fwnode: fix v4l2_fwnode_parse_link handling

From: Marco Felsch <hidden>
Date: 2020-03-12 11:15:01
Also in: linux-media

Hi Sakari,

On 20-03-12 12:43, Sakari Ailus wrote:
On Thu, Mar 12, 2020 at 12:42:22PM +0200, Sakari Ailus wrote:
quoted
On Thu, Mar 12, 2020 at 11:31:39AM +0100, Marco Felsch wrote:
quoted
Currently the driver differentiate the port number property handling for
ACPI and DT. This is wrong as because ACPI should use the "reg" val too
[1].

[1] https://patchwork.kernel.org/patch/11421985/

Fixes: ca50c197bd96 ("[media] v4l: fwnode: Support generic fwnode for parsing standardised properties")
Signed-off-by: Marco Felsch <redacted>
Oh well, I guess this is OK; I noticed the next patch that depends on this
one. But it should be merged with the next patch so that it won't be
accidentally backported alone.

Then, please add:

Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Forgot that no ACPI driver uses it. So _no_ changes are needed to this, and
you can add the ack.

Thanks.
I thought about it too and in the end I splitted the patche for possible
backport reasons. Squashing shouldn't be a problem for Hans?

Regards,
  Marco
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help