Re: [PATCH 2/2] ARM: DTS: Add devicetree file for the Galaxy S2
From: Marek Szyprowski <m.szyprowski@samsung.com>
Date: 2020-03-31 05:36:46
Also in:
linux-arm-kernel, linux-samsung-soc, lkml
Possibly related (same subject, not in this thread)
- 2020-03-18 · Re: [PATCH 2/2] ARM: DTS: Add devicetree file for the Galaxy S2 · Krzysztof Kozlowski <krzk@kernel.org>
- 2020-03-13 · Re: [PATCH 2/2] ARM: DTS: Add devicetree file for the Galaxy S2 · Marek Szyprowski <m.szyprowski@samsung.com>
- 2020-03-13 · Re: [PATCH 2/2] ARM: DTS: Add devicetree file for the Galaxy S2 · Paul Cercueil <paul@crapouillou.net>
- 2020-03-13 · Re: [PATCH 2/2] ARM: DTS: Add devicetree file for the Galaxy S2 · Paul Cercueil <paul@crapouillou.net>
- 2020-03-13 · Re: [PATCH 2/2] ARM: DTS: Add devicetree file for the Galaxy S2 · Paul Cercueil <paul@crapouillou.net>
Hi Paul, On 2020-03-18 15:25, Paul Cercueil wrote:
quoted
quoted
+ }; + + tsp_reg: regulator-1 { + compatible = "regulator-fixed"; + regulator-name = "TSP_FIXED_VOLTAGES"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + gpio = <&gpl0 3 GPIO_ACTIVE_HIGH>; + startup-delay-us = <70000>; + enable-active-high; + regulator-boot-on; + regulator-always-on;always-on and boot-on should not be needed. You have a consumer for this regulator.About this: the touchscreen driver does not use a regulator, so I believe that's why these properties were here. I sent patches upstream to address the issue: https://lkml.org/lkml/2020/3/15/94 I believe this means I cannot merge the i9100 devicetree until it is acked.
One more information - similar change has been already posted, but it looks it got lost then: https://patchwork.kernel.org/patch/10550903/ Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland