Re: [PATCH v5 1/4] dt-bindings: Add cros-ec Type C port driver
From: Benson Leung <hidden>
Date: 2020-03-26 00:10:33
Also in:
lkml
Hi Prashant, On Mon, Mar 16, 2020 at 02:00:15AM -0700, Prashant Malani wrote:
Some Chrome OS devices with Embedded Controllers (EC) can read and modify Type C port state. Add an entry in the DT Bindings documentation that lists out the logical device and describes the relevant port information, to be used by the corresponding driver. Signed-off-by: Prashant Malani <redacted>
Reviewed-by: Benson Leung <bleung@chromium.org> Hi Rob, Will you go ahead and merge this through your tree for v5.7? Thanks, Benson
quoted hunk ↗ jump to hunk
--- Changes in v5: - Updated License identifier. - Updated DT example to be a full example. Changes in v4: - Rebased on top of usb-connector.yaml, so the connector property now directly references the usb-connector DT binding. .../bindings/chrome/google,cros-ec-typec.yaml | 54 +++++++++++++++++++ 1 file changed, 54 insertions(+) create mode 100644 Documentation/devicetree/bindings/chrome/google,cros-ec-typec.yamldiff --git a/Documentation/devicetree/bindings/chrome/google,cros-ec-typec.yaml b/Documentation/devicetree/bindings/chrome/google,cros-ec-typec.yaml new file mode 100644 index 0000000000000..6d7396ab8beec --- /dev/null +++ b/Documentation/devicetree/bindings/chrome/google,cros-ec-typec.yaml@@ -0,0 +1,54 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/chrome/google,cros-ec-typec.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Google Chrome OS EC(Embedded Controller) Type C port driver. + +maintainers: + - Benson Leung <bleung@chromium.org> + - Prashant Malani <pmalani@chromium.org> + +description: + Chrome OS devices have an Embedded Controller(EC) which has access to + Type C port state. This node is intended to allow the host to read and + control the Type C ports. The node for this device should be under a + cros-ec node like google,cros-ec-spi. + +properties: + compatible: + const: google,cros-ec-typec + + connector: + $ref: /schemas/connector/usb-connector.yaml# + +required: + - compatible + +examples: + - |+ + spi0 { + #address-cells = <1>; + #size-cells = <0>; + + cros_ec: ec@0 { + compatible = "google,cros-ec-spi"; + reg = <0>; + + typec { + compatible = "google,cros-ec-typec"; + + #address-cells = <1>; + #size-cells = <0>; + + connector@0 { + compatible = "usb-c-connector"; + reg = <0>; + power-role = "dual"; + data-role = "dual"; + try-power-role = "source"; + }; + }; + }; + };-- 2.25.1.481.gfbce0eb801-goog
-- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. bleung@google.com Chromium OS Project bleung@chromium.org
Attachments
- signature.asc [application/pgp-signature] 228 bytes