Re: [PATCH 08/10] powerpc/fsl: Make serial ports compatible with ns16550a
From: Rob Herring <robh+dt@kernel.org>
Date: 2020-03-23 17:59:32
Also in:
linux-serial, linuxppc-dev, lkml
From: Rob Herring <robh+dt@kernel.org>
Date: 2020-03-23 17:59:32
Also in:
linux-serial, linuxppc-dev, lkml
On Fri, Mar 20, 2020 at 11:41 AM Lubomir Rintel [off-list ref] wrote:
There are separate compatible strings for ns16550 and ns16550a and the Freescale serial port is compatible with the latter one, with working FIFO.
I don't think changing this is right. First, 'ns16550' is what's documented in the DT spec (and ePAPR which it's based on). Second, these dts files are pretty mature/stable, so I'm less inclined to change them. AFAICT, this change either enables the fifo (which would be an untested change in behavior) or has no effect because the fifo is auto-detected.
Use the appropriate compatible string that is also consistent with ARM64 Freescale boards and thus avoiding one special case in the binding schema.
Well, that's annoying... Rob