Hi Laurent,

Thank you for the quick review.

-----Original Message-----
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Sent: 13 March 2020 21:20
To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>; Shawn Guo
[off-list ref]; Sascha Hauer [off-list ref];
Pengutronix Kernel Team [off-list ref]; Rob Herring
[off-list ref]; Mark Rutland [off-list ref]; Sakari
Ailus [off-list ref]; NXP Linux Team [off-list ref];
Magnus Damm [off-list ref]; Ezequiel Garcia
[off-list ref]; Geert Uytterhoeven [off-list ref];
devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-renesas-
soc@vger.kernel.org; Fabio Estevam [off-list ref]; linux-
media@vger.kernel.org; linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/4] media: dt-bindings: media: i2c: Switch to
assigned-clock-rates

Hi Prabhakar,

Thank you for the patch.

On Fri, Mar 13, 2020 at 09:12:31PM +0000, Lad Prabhakar wrote:

quoted

Use assigned-clock-rates to specify the clock rate. Also mark
clock-frequency property as deprecated.

I would phrase it the other way around, this patch mainly deprecates clock-
frequency, and as a side effect recommends usage of assigned-clock-rates.

"Deprecate usage of the clock-frequency propertly. The preferred method
to set clock rates is to use assigned-clock-rates."

Agreed will do that.

quoted

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-

lad.rj@bp.renesas.com>

quoted

---
 Documentation/devicetree/bindings/media/i2c/ov5645.txt | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/i2c/ov5645.txt

b/Documentation/devicetree/bindings/media/i2c/ov5645.txt
index 72ad992..e62fe82 100644

--- a/Documentation/devicetree/bindings/media/i2c/ov5645.txt
+++ b/Documentation/devicetree/bindings/media/i2c/ov5645.txt

@@ -8,7 +8,7 @@ Required Properties:
 - compatible: Value should be "ovti,ov5645".
 - clocks: Reference to the xclk clock.
 - clock-names: Should be "xclk".
-- clock-frequency: Frequency of the xclk clock.
+- clock-frequency (deprecated): Frequency of the xclk clock.

I would drop this completely. Drivers need to ensure backward compatibility,
but DT bindings should only document the latest version, the history is
available in git.

Sure will drop it.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

While at it, can I enlist you to convert these bindings to yaml ? :-)

Sure will do the honours 😊, will make sure yaml patch is ontop of this patch too.

Cheers,
--Prabhakar

quoted

 - enable-gpios: Chip enable GPIO. Polarity is GPIO_ACTIVE_HIGH. This

corresponds

quoted

   to the hardware pin PWDNB which is physically active low.
 - reset-gpios: Chip reset GPIO. Polarity is GPIO_ACTIVE_LOW. This
corresponds to @@ -37,7 +37,8 @@ Example:

 clocks = <&clks 200>;
 clock-names = "xclk";
-clock-frequency = <24000000>;
+assigned-clocks = <&clks 200>;
+assigned-clock-rates = <24000000>;

 vdddo-supply = <&camera_dovdd_1v8>;
 vdda-supply = <&camera_avdd_2v8>;

--
Regards,

Laurent Pinchart

Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647