Re: [PATCH v3 4/5] dt-bindings: display: add data-mapping to panel-dpi

On Tue, Feb 18, 2020 at 11:16:38PM +0100, Sam Ravnborg wrote:

On Tue, Feb 18, 2020 at 02:13:45PM -0600, Rob Herring wrote:

quoted

On Sun, Feb 16, 2020 at 12:15 PM Sam Ravnborg [off-list ref] wrote:

quoted

Add data-mapping property that can be used to specify
the media format used for the connection betwwen the
display controller (connector) and the panel.
Signed-off-by: Sam Ravnborg <redacted>

Missing blank line.

quoted

---
 .../devicetree/bindings/display/panel/panel-dpi.yaml | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml b/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml
index 40079fc24a63..6a03d2449701 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml

@@ -21,6 +21,16 @@ properties:
       - {}
       - const: panel-dpi

+  data-mapping:
+    enum:
+      - rgb24
+      - rgb565
+      - bgr666
+      - lvds666

Doesn't lvds666 come from i.MX IPU which as I remember has built-in
LVDS block? I'd think this format would be implicit when using the
LVDS block and panel. It doesn't seem this is actually used anywhere
either.

I must admit that I just copied this list from Oleksandrs original
patch. The MEDIA type it identifies(MEDIA_BUS_FMT_RGB666_1X24_CPADHI) looks special.
I will drop lvds666 while applying, unless I get other feedback.
(Note: travelling, earliest in the weekend)

Okay, with that:

Reviewed-by: Rob Herring <robh@kernel.org>

Btw. anyway I can add data-mapping to panel-common - and then list the
allowed enum values in each binding?

That would be good. It should be defined explicitly that it's a single 
string as that's implicit currently.
 
Rob