Re: [PATCH v3 1/4] dt-bindings: PCI: Add PCI Endpoint Controller Schema
From: Rob Herring <robh@kernel.org>
Date: 2020-02-28 15:34:15
Also in:
linux-pci, lkml
On Mon, Feb 24, 2020 at 06:39:02PM +0530, Kishon Vijay Abraham I wrote:
quoted hunk ↗ jump to hunk
Define a common schema for PCI Endpoint Controllers. Signed-off-by: Kishon Vijay Abraham I <redacted> --- .../devicetree/bindings/pci/pci-ep.yaml | 41 +++++++++++++++++++ 1 file changed, 41 insertions(+) create mode 100644 Documentation/devicetree/bindings/pci/pci-ep.yamldiff --git a/Documentation/devicetree/bindings/pci/pci-ep.yaml b/Documentation/devicetree/bindings/pci/pci-ep.yaml new file mode 100644 index 000000000000..2287771a066a --- /dev/null +++ b/Documentation/devicetree/bindings/pci/pci-ep.yaml@@ -0,0 +1,41 @@ +# SPDX-License-Identifier: (GPL2.0-only OR BSD-2-Clause)
Typo. Run checkpatch.
+%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pci/pci-ep.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: PCI Endpoint Controller Schema + +description: | + Common properties for PCI Endpoint Controller Nodes. + +maintainers: + - Kishon Vijay Abraham I [off-list ref] + +properties: + $nodename: + pattern: "^pcie-ep?@"
Why the '?'? Let's define the name and fix anything that doesn't match.
+ + max-functions: + description: Maximum number of functions that can be configured + allOf: + - $ref: /schemas/types.yaml#/definitions/uint8 + minimum: 1 + default: 1 + maximum: 255 + + max-link-speed: + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + enum: [ 1, 2, 3, 4 ] + + num-lanes: + description: maximum number of lanes + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 1 + default: 1 + maximum: 16 + +required: + - compatible -- 2.17.1