Re: [PATCH v5 7/7] dt-bindings: usb: add documentation for aspeed usb-vhub
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2020-02-27 23:30:55
Also in:
linux-arm-kernel, linux-aspeed, linux-usb, lkml, openbmc
On Thu, 2020-02-27 at 15:05 -0800, rentao.bupt@gmail.com wrote: .../... You haven't fixed the problem spotted by Rob which is that the example is now out of sync, it's missing the required properties. Also long run I think best is going to have a child node per downstream port, so we create a matching linux struct device. This will make it easier to deal with the other device-controller in the ast2600 which is basically one of these without a vhub above it.
+required:
+ - compatible
+ - reg
+ - clocks
+ - interrupts
+ - aspeed,vhub-downstream-ports
+ - aspeed,vhub-generic-endpoints
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/aspeed-clock.h>
+ vhub: usb-vhub@1e6a0000 {
+ compatible = "aspeed,ast2500-usb-vhub";
+ reg = <0x1e6a0000 0x300>;
+ interrupts = <5>;
+ clocks = <&syscon ASPEED_CLK_GATE_USBPORT1CLK>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usb2ad_default>;
+ };
--