RE: [PATCHv10 00/13] PCI: Recode Mobiveil driver and add PCIe Gen4 driver for NXP Layerscape SoCs

Hi Lorenzo,

-----Original Message-----
From: Lorenzo Pieralisi <redacted>
Sent: 2020年2月21日 20:20
To: Z.q. Hou <zhiqiang.hou@nxp.com>
Cc: linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
bhelgaas@google.com; robh+dt@kernel.org; andrew.murray@arm.com;
arnd@arndb.de; mark.rutland@arm.com; l.subrahmanya@mobiveil.co.in;
shawnguo@kernel.org; m.karthikeyan@mobiveil.co.in; Leo Li
[off-list ref]; catalin.marinas@arm.com; will.deacon@arm.com;
Mingkai Hu [off-list ref]; M.h. Lian [off-list ref];
Xiaowei Bao [off-list ref]
Subject: Re: [PATCHv10 00/13] PCI: Recode Mobiveil driver and add PCIe
Gen4 driver for NXP Layerscape SoCs

On Thu, Feb 13, 2020 at 12:06:31PM +0800, Zhiqiang Hou wrote:

quoted

From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>

This patch set is to recode the Mobiveil driver and add PCIe support
for NXP Layerscape series SoCs integrated Mobiveil's PCIe Gen4
controller.

Hou Zhiqiang (13):
  PCI: mobiveil: Introduce a new structure mobiveil_root_port
  PCI: mobiveil: Move the host initialization into a function
  PCI: mobiveil: Collect the interrupt related operations into a
    function
  PCI: mobiveil: Modularize the Mobiveil PCIe Host Bridge IP driver
  PCI: mobiveil: Add callback function for interrupt initialization
  PCI: mobiveil: Add callback function for link up check
  PCI: mobiveil: Allow mobiveil_host_init() to be used to re-init host
  PCI: mobiveil: Add 8-bit and 16-bit CSR register accessors
  PCI: mobiveil: Add Header Type field check
  dt-bindings: PCI: Add NXP Layerscape SoCs PCIe Gen4 controller
  PCI: mobiveil: Add PCIe Gen4 RC driver for NXP Layerscape SoCs
  arm64: dts: lx2160a: Add PCIe controller DT nodes
  arm64: defconfig: Enable CONFIG_PCIE_LAYERSCAPE_GEN4

 .../bindings/pci/layerscape-pcie-gen4.txt     |  52 ++
 MAINTAINERS                                   |  10 +-
 .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 163 +++++
 arch/arm64/configs/defconfig                  |   1 +
 drivers/pci/controller/Kconfig                |  11 +-
 drivers/pci/controller/Makefile               |   2 +-
 drivers/pci/controller/mobiveil/Kconfig       |  33 +
 drivers/pci/controller/mobiveil/Makefile      |   5 +
 .../mobiveil/pcie-layerscape-gen4.c           | 267 +++++++++
 .../pcie-mobiveil-host.c}                     | 564 ++++--------------
 .../controller/mobiveil/pcie-mobiveil-plat.c  |  61 ++
 .../pci/controller/mobiveil/pcie-mobiveil.c   | 230 +++++++
 .../pci/controller/mobiveil/pcie-mobiveil.h   | 226 +++++++
 13 files changed, 1170 insertions(+), 455 deletions(-)  create mode
100644 Documentation/devicetree/bindings/pci/layerscape-pcie-gen4.txt
 create mode 100644 drivers/pci/controller/mobiveil/Kconfig
 create mode 100644 drivers/pci/controller/mobiveil/Makefile
 create mode 100644
drivers/pci/controller/mobiveil/pcie-layerscape-gen4.c
 rename drivers/pci/controller/{pcie-mobiveil.c =>
mobiveil/pcie-mobiveil-host.c} (54%)  create mode 100644
drivers/pci/controller/mobiveil/pcie-mobiveil-plat.c
 create mode 100644 drivers/pci/controller/mobiveil/pcie-mobiveil.c
 create mode 100644 drivers/pci/controller/mobiveil/pcie-mobiveil.h

I dropped the last two patches since they must be re-routed via arm-soc
(defconfig update and dts), I tweaked most of commit logs and applied the
series to pci/mobiveil, please check everything is in order.

 
Thanks a lot for your help on the commit logs!

Thanks,
Zhiqiang

Thanks,
Lorenzo