Re: [PATCH v3,1/8] arm64: dts: mt8183: add thermal zone node
From: Matthias Brugger <matthias.bgg@gmail.com>
Date: 2020-02-20 20:57:34
Also in:
linux-arm-kernel, linux-mediatek, linux-pm, lkml
On 20/02/2020 12:52, Daniel Lezcano wrote:
On 11/02/2020 04:17, Michael Kao wrote:quoted
On Thu, 2020-01-09 at 12:31 +0100, Daniel Lezcano wrote:quoted
On 03/01/2020 07:44, Michael Kao wrote:quoted
From: "michael.kao" <redacted> Add thermal zone node to Mediatek MT8183 dts file. Signed-off-by: Michael Kao <redacted> --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 85 ++++++++++++++++++++++++ 1 file changed, 85 insertions(+)diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi index 10b32471bc7b..a2793cf3d994 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi@@ -570,6 +570,88 @@ status = "disabled"; }; + thermal: thermal@1100b000 { + #thermal-sensor-cells = <1>; + compatible = "mediatek,mt8183-thermal"; + reg = <0 0x1100b000 0 0x1000>; + interrupts = <0 76 IRQ_TYPE_LEVEL_LOW>;What is this interrupt for?The interrupts pin is designed in our SoC. But it is not used in our upstream thermal code now. There is also add the settings but not use for mt8173.dtsi. To align the thermal dtsi format, I follow the past experience to add the interrupt settings of this project first.Assuming the interrupt can be set by the driver to fire when a specified temperature is set, I suggest to change your driver to handle it so you can get rid of the polling waking up the SoC every second.
For the record the interrupt is a required property by the binding description. Regards, Matthias