Re: [PATCH v8 11/22] ASoC: tegra: Add fallback implementation for audio mclk
From: Dmitry Osipenko <digetx@gmail.com>
Date: 2020-02-17 14:51:53
Also in:
linux-clk, linux-tegra, lkml
From: Dmitry Osipenko <digetx@gmail.com>
Date: 2020-02-17 14:51:53
Also in:
linux-clk, linux-tegra, lkml
17.02.2020 12:40, Thierry Reding пишет:
On Mon, Jan 13, 2020 at 11:24:16PM -0800, Sowjanya Komatineni wrote:quoted
mclk is from clk_out_1 which is part of Tegra PMC block and pmc clocks are moved to Tegra PMC driver with pmc as clock provider and using pmc clock ids. New device tree uses clk_out_1 from pmc clock provider as audio mclk. So, this patch adds implementation for mclk fallback to extern1 when retrieving mclk returns -ENOENT to be backward compatible of new device tree with older kernels. Fixes: 110147c8c513 ("ASoC: tegra: always use clk_get() in utility code") Tested-by: Dmitry Osipenko <digetx@gmail.com> Reviewed-by: Dmitry Osipenko <digetx@gmail.com> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> --- sound/soc/tegra/tegra_asoc_utils.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-)There's some inconsistent spelling of PMC in the above, but other than that: Acked-by: Thierry Reding <redacted>
Seems you missed my point.. this patch doesn't work at all, and thus, it should be dropped.