Re: [PATCH v2 1/2] dt-bindings: clock: Add binding documentation for TI syscon gate clock

Hi,

On 2/11/2020 12:15 AM, Stephen Boyd wrote:

Quoting Vignesh Raghavendra (2020-02-06 20:44:24)

[...]

quoted

+  - Vignesh Raghavendra [off-list ref]
+
+description: |
+
+  This binding uses common clock bindings
+  Documentation/devicetree/bindings/clock/clock-bindings.txt

Maybe have a real description instead of this line which is mostly
useless.

Will drop this line..

quoted

+
+properties:
+  compatible:
+    items:

I think you can drop items.

quoted

+      - const: ti,am654-ehrpwm-tbclk
+
+  "#clock-cells":
+    const: 1
+
+  ti,tbclk-syscon:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description:
+      Phandle to the system controller node that has bits to
+      control eHRPWM's TBCLK
+
+required:
+  - compatible
+  - "#clock-cells"
+  - ti,tbclk-syscon
+
+examples:
+  - |
+    tbclk_ctrl: tbclk_ctrl@4140 {
+        compatible = "syscon";
+        reg = <0x4140 0x18>;
+    };
+
+    ehrpwm_tbclk: clk0 {
+        compatible = "ti,am654-ehrpwm-tbclk";
+        #clock-cells = <1>;
+        ti,tbclk-syscon = <&tbclk_ctrl>;
+    };

I don't understand the binding. Why can't the syscon node register clks
and have #clock-cells?

I did not know that would work. Will make syscon code to register clks..
Thanks!

Regards
Vignesh