Hi Rob,

Thanks for the review.

-----Original Message-----
From: Rob Herring <robh@kernel.org>
Sent: Friday, February 7, 2020 2:25
To: Yuti Suresh Amonkar <redacted>
Cc: linux-kernel@vger.kernel.org; devicetree@vger.kernel.org;
kishon@ti.com; robh+dt@kernel.org; mark.rutland@arm.com;
maxime@cerno.tech; jsarha@ti.com; tomi.valkeinen@ti.com;
praneeth@ti.com; Milind Parab [off-list ref]; Swapnil Kashinath
Jakhade [off-list ref]; Yuti Suresh Amonkar
[off-list ref]
Subject: Re: [PATCH v4 02/13] dt-bindings: phy: Add Cadence MHDP PHY
bindings in YAML format.

EXTERNAL MAIL


On Thu, 6 Feb 2020 07:10:50 +0100, Yuti Amonkar wrote:

quoted

- Add Cadence MHDP PHY bindings in YAML format.
- Add Torrent PHY reference clock bindings.
- Add sub-node bindings for each group of PHY lanes based on PHY type.
  Each sub-node includes properties such as master lane number, link reset,
  phy type, number of lanes etc.
- Add reset support including PHY reset and individual lane reset.
- Add a new compatible string used for TI SoCs using Torrent PHY.
This will not affect ABI as the driver has never been functional, and
therefore do not exist in any active use case.

Signed-off-by: Yuti Amonkar <redacted>
---
 .../bindings/phy/phy-cadence-torrent.yaml     | 143 ++++++++++++++++++
 1 file changed, 143 insertions(+)
 create mode 100644
Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml

My bot found errors running 'make dt_binding_check' on your patch:

Documentation/devicetree/bindings/display/simple-
framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root):
/example-0/chosen: chosen node must be at root node
Error: Documentation/devicetree/bindings/phy/phy-cadence-
torrent.example.dts:33.42-43 syntax error FATAL ERROR: Unable to parse
input tree
scripts/Makefile.lib:300: recipe for target
'Documentation/devicetree/bindings/phy/phy-cadence-
torrent.example.dt.yaml' failed
make[1]: *** [Documentation/devicetree/bindings/phy/phy-cadence-
torrent.example.dt.yaml] Error 1
Makefile:1263: recipe for target 'dt_binding_check' failed
make: *** [dt_binding_check] Error 2

I think this error is due to missing PHY_TYPE_DP macro in the include/dt-bindings/phy/phy.h file. This macro is defined in the patch [1] which is available in phy-next. I forgot to mention dependency of this patch series on [1]. Should I send the series again by mentioning the dependency in the cover letter?

[1]
https://lkml.org/lkml/2019/12/9/586

See https://urldefense.proofpoint.com/v2/url?u=https-
3A__patchwork.ozlabs.org_patch_1234141&d=DwIBAg&c=aUq983L2pue2Fq
KFoP6PGHMJQyoJ7kl3s3GZ-
_haXqY&r=xythEVTj32hrXbonw_U5uD9n5Dh9J7TTTznvmGAGKo4&m=4HxnP
HG3MyXrwx28RZFwK7SF4T0LlYYpDjAaJcJ0lXI&s=zp6pUcrsuA4OAIRcws8y1rxY
xC4OrNk7GCrLcWqE0z8&e=
Please check and re-submit.

Thanks & Regards,
Yuti Amonkar