Re: [PATCH v3 2/3] lib/vsprintf: introduce OF_DEVICE_NODE_FLAG_MAX
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2020-01-20 14:16:46
Also in:
linux-doc
On Mon, Jan 20, 2020 at 07:38:28PM +0800, lijiazi wrote:
introduce OF_DEVICE_NODE_FLAG_MAX for %pOF related printk.
introduce -> Introduce
quoted hunk ↗ jump to hunk
@@ -147,6 +147,13 @@ extern raw_spinlock_t devtree_lock; #define OF_OVERLAY 5 /* allocated for an overlay */ #define OF_OVERLAY_FREE_CSET 6 /* in overlay cset being freed */
+/* + * add OF_DEVICE_NODE_FLAG_MAX for %pOF related printk. + * if there is any change on these flags, please synchronize the change + * to device_node_string function in lib/vsprintf.c.
This is doubtful comment. If we don't want to print some flags in printf()? And in general this is orthogonal to the printf() changes.
+ */ +#define OF_DEVICE_NODE_FLAG_MAX 6 /* Maximum available flags */
-- With Best Regards, Andy Shevchenko