Re: [PATCH v2 2/2] arm64: dts: mediatek: add mt8173 elm and hana board

On 15/01/2020 09:53, Hsin-Yi Wang wrote:

On Tue, Jan 14, 2020 at 11:10 PM Matthias Brugger
[off-list ref] wrote:

quoted

On 13/01/2020 19:01, Hsin-Yi Wang wrote:

quoted

On Fri, Jan 10, 2020 at 9:42 PM Matthias Brugger [off-list ref] wrote:

quoted

Thanks, I will address the comments and send next version

quoted

On 10/01/2020 08:37, Hsin-Yi Wang wrote:

quoted

Elm is Acer Chromebook R13. Hana is Lenovo Chromebook. Both uses mt8173
SoC.

Signed-off-by: Hsin-Yi Wang <redacted>
---
Changes in v2:
- remove downstream nodes and unused nodes
- use GPIO_ACTIVE_LOW for ps8640 gpios
- move trackpad to hana
---
 arch/arm64/boot/dts/mediatek/Makefile         |    3 +
 .../dts/mediatek/mt8173-elm-hana-rev7.dts     |   27 +
 .../boot/dts/mediatek/mt8173-elm-hana.dts     |   16 +
 .../boot/dts/mediatek/mt8173-elm-hana.dtsi    |   60 +
 arch/arm64/boot/dts/mediatek/mt8173-elm.dts   |   15 +
 arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi  | 1040 +++++++++++++++++
 6 files changed, 1161 insertions(+)
 create mode 100644 arch/arm64/boot/dts/mediatek/mt8173-elm-hana-rev7.dts
 create mode 100644 arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dts
 create mode 100644 arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtsi
 create mode 100644 arch/arm64/boot/dts/mediatek/mt8173-elm.dts
 create mode 100644 arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi

[...]

quoted

quoted

quoted

quoted

+                     compatible = "mediatek,mt6397-rtc";
+             };
+
+             syscfg_pctl_pmic: syscfg_pctl_pmic@c000 {
+                     compatible = "mediatek,mt6397-pctl-pmic-syscfg",
+                                  "syscon";
+                     reg = <0 0x0000c000 0 0x0108>;

not an upstream compatible, please delete the node.

I think my comment was not correct. I'll have to dig more to understand why we
have a compatible without a binding description.

Here's a similar syscon node that is in a binding document's example:

syscfg_pctl_a: syscfg-pctl-a@10005000 {
        compatible = "mediatek,mt8135-pctl-a-syscfg", "syscon";
        reg = <0 0x10005000 0 0x1000>;
};

https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/pinctrl/pinctrl-mt65xx.txt#L81

Yes I know, that's why I said that my first comment was not correct. Just leave
it in.

Regards,
Matthias