Thread (8 messages) 8 messages, 7 authors, 2020-01-08

Re: [PATCH] treewide: remove redundent IS_ERR() before error code check

From: Wolfram Sang <hidden>
Date: 2020-01-06 10:06:07
Also in: alsa-devel, linux-acpi, linux-arm-kernel, linux-clk, linux-crypto, linux-gpio, linux-i2c, lkml, netdev

On Mon, Jan 06, 2020 at 01:58:33PM +0900, Masahiro Yamada wrote:
'PTR_ERR(p) == -E*' is a stronger condition than IS_ERR(p).
Hence, IS_ERR(p) is unneeded.

The semantic patch that generates this commit is as follows:

// <smpl>
@@
expression ptr;
constant error_code;
@@
-IS_ERR(ptr) && (PTR_ERR(ptr) == - error_code)
+PTR_ERR(ptr) == - error_code
// </smpl>

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
For drivers/i2c:

Acked-by: Wolfram Sang <redacted>

Thanks!

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help