On Mon, Dec 23, 2019 at 2:06 PM Fabio Estevam [off-list ref] wrote:

Hi Robert,

On Mon, Dec 23, 2019 at 6:44 PM Robert Jones [off-list ref] wrote:

quoted

The Gateworks GW5907 is an IMX6 SoC based single board computer with:
 - IMX6Q or IMX6DL
 - 32bit DDR3 DRAM
 - FEC GbE Phy
 - bi-color front-panel LED
 - 256MB NAND boot device
 - Gateworks System Controller (hwmon, pushbutton controller, EEPROM)
 - Digital IO expander (pca9555)
 - Joystick 12bit adc (ads1015)

Signed-off-by: Tim Harvey <tharvey@gateworks.com>
Signed-off-by: Robert Jones <redacted>

Not clear on the authorship on this patch.

If the original author is Tim, then his name should appear in the From field.

Original author for all but the GW5910 patch was myself. It's probably
not clear here but Tim reviewed the patches prior to submission and
had me add him as a Signed-off-by.

Would it be better to just remove those lines from the patches in this case?

quoted

---
 arch/arm/boot/dts/Makefile            |   2 +
 arch/arm/boot/dts/imx6dl-gw5907.dts   |  14 ++
 arch/arm/boot/dts/imx6q-gw5907.dts    |  14 ++
 arch/arm/boot/dts/imx6qdl-gw5907.dtsi | 399 ++++++++++++++++++++++++++++++++++
 4 files changed, 429 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx6dl-gw5907.dts
 create mode 100644 arch/arm/boot/dts/imx6q-gw5907.dts
 create mode 100644 arch/arm/boot/dts/imx6qdl-gw5907.dtsi

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 1e9e1af..9ee80e2 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile

@@ -422,6 +422,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
        imx6dl-gw560x.dtb \
        imx6dl-gw5903.dtb \
        imx6dl-gw5904.dtb \
+       imx6dl-gw5907.dtb \

You should add an additional patch that add these new boards in
Documentation/devicetree/bindings/arm/fsl.yaml

So I was planning on just adding an enum line for "gw,ventana" under
the i.MX6DL and i.MX6Q based Boards sections. Would that be
sufficient?

We have a lot of individual custom boards and it doesn't seem correct
to add individual strings for every one in both sections.