Hi,

-----Original Message-----
From: Rob Herring <robh@kernel.org>
Sent: Friday, December 20, 2019 2:41
To: Yuti Suresh Amonkar <redacted>
Cc: linux-kernel@vger.kernel.org; devicetree@vger.kernel.org;
kishon@ti.com; mark.rutland@arm.com; jsarha@ti.com;
tomi.valkeinen@ti.com; praneeth@ti.com; Milind Parab
[off-list ref]; Swapnil Kashinath Jakhade
[off-list ref]
Subject: Re: [RESEND PATCH v1 02/15] dt-bindings:phy: Convert Cadence
MHDP PHY bindings to YAML.

EXTERNAL MAIL


On Wed, Dec 11, 2019 at 02:09:07PM +0100, Yuti Amonkar wrote:

quoted

- Convert the MHDP PHY devicetree bindings to yaml schemas.

quoted

- Rename DP PHY to have generic Torrent PHY nomrnclature.

quoted

- Rename compatible string from "cdns,dp-phy" to "cdns,torrent-phy".

You can't just change compatible strings. It's an ABI. Unless you know

for sure there are no users that would care.

The driver has never been functional and therefore not used in any active use cases. We will update this in the commit description 
of next patch series.

quoted

quoted

Signed-off-by: Yuti Amonkar <redacted>

quoted

---

quoted

 .../devicetree/bindings/phy/phy-cadence-dp.txt     | 30 ------------

quoted

 .../bindings/phy/phy-cadence-torrent.yaml          | 57

++++++++++++++++++++++

quoted

 2 files changed, 57 insertions(+), 30 deletions(-)

quoted

 delete mode 100644 Documentation/devicetree/bindings/phy/phy-

cadence-dp.txt

quoted

 create mode 100644 Documentation/devicetree/bindings/phy/phy-

cadence-torrent.yaml

quoted

quoted

diff --git a/Documentation/devicetree/bindings/phy/phy-cadence-dp.txt

b/Documentation/devicetree/bindings/phy/phy-cadence-dp.txt

quoted

deleted file mode 100644

quoted

index 7f49fd54e..0000000

quoted

--- a/Documentation/devicetree/bindings/phy/phy-cadence-dp.txt

quoted

+++ /dev/null

quoted

@@ -1,30 +0,0 @@

quoted

-Cadence MHDP DisplayPort SD0801 PHY binding

quoted

-===========================================

quoted

-

quoted

-This binding describes the Cadence SD0801 PHY hardware included with

quoted

-the Cadence MHDP DisplayPort controller.

quoted

-

quoted

--------------------------------------------------------------------------------

quoted

-Required properties (controller (parent) node):

quoted

-- compatible	: Should be "cdns,dp-phy"

quoted

-- reg		: Defines the following sets of registers in the parent

quoted

-		  mhdp device:

quoted

-			- Offset of the DPTX PHY configuration registers

quoted

-			- Offset of the SD0801 PHY configuration registers

quoted

-- #phy-cells	: from the generic PHY bindings, must be 0.

quoted

-

quoted

-Optional properties:

quoted

-- num_lanes	: Number of DisplayPort lanes to use (1, 2 or 4)

quoted

-- max_bit_rate	: Maximum DisplayPort link bit rate to use, in Mbps

(2160,

quoted

-		  2430, 2700, 3240, 4320, 5400 or 8100)

quoted

--------------------------------------------------------------------------------

quoted

-

quoted

-Example:

quoted

-	dp_phy: phy@f0fb030a00 {

quoted

-		compatible = "cdns,dp-phy";

quoted

-		reg = <0xf0 0xfb030a00 0x0 0x00000040>,

quoted

-		      <0xf0 0xfb500000 0x0 0x00100000>;

quoted

-		num_lanes = <4>;

quoted

-		max_bit_rate = <8100>;

quoted

-		#phy-cells = <0>;

quoted

-	};

quoted

diff --git a/Documentation/devicetree/bindings/phy/phy-cadence-

torrent.yaml b/Documentation/devicetree/bindings/phy/phy-cadence-
torrent.yaml

quoted

new file mode 100644

quoted

index 0000000..4fa9d0a

quoted

--- /dev/null

quoted

+++ b/Documentation/devicetree/bindings/phy/phy-cadence-

torrent.yaml



Normal file naming is using the compatible string.

quoted

@@ -0,0 +1,57 @@

quoted

+%YAML 1.2

quoted

+---

quoted

+$id: "https://urldefense.proofpoint.com/v2/url?u=http-

3A__devicetree.org_schemas_phy_phy-2Dcadence-2Dtorrent.yaml-
23&d=DwIBAg&c=aUq983L2pue2FqKFoP6PGHMJQyoJ7kl3s3GZ-
_haXqY&r=xythEVTj32hrXbonw_U5uD9n5Dh9J7TTTznvmGAGKo4&m=9-
kyiRknYkYa5DqMjgD8NdzvcteoR6ElMbozga1HYMw&s=R0d1BN7TnO9WvU1
Wd1msGE7rObNLWn_xhVoW247Ggu0&e= "

quoted

+$schema: "https://urldefense.proofpoint.com/v2/url?u=http-

3A__devicetree.org_meta-2Dschemas_core.yaml-
23&d=DwIBAg&c=aUq983L2pue2FqKFoP6PGHMJQyoJ7kl3s3GZ-
_haXqY&r=xythEVTj32hrXbonw_U5uD9n5Dh9J7TTTznvmGAGKo4&m=9-
kyiRknYkYa5DqMjgD8NdzvcteoR6ElMbozga1HYMw&s=uIcZwMHgTJIbhKM1q
hWr_-4NoZWn5KaohCrVBA28Ruk&e= "

quoted

+

quoted

+title: Cadence Torrent SD0801 PHY binding for DisplayPort

quoted

+

quoted

+description:

quoted

+  This binding describes the Cadence SD0801 PHY hardware included with

quoted

+  the Cadence MHDP DisplayPort controller.

quoted

+

quoted

+maintainers:

quoted

+  - Swapnil Jakhade [off-list ref]

quoted

+  - Yuti Amonkar [off-list ref]

quoted

+

quoted

+properties:

quoted

+  compatible:

quoted

+    const: cdns,torrent-phy

quoted

+

quoted

+  reg:

quoted

+    items:

quoted

+      - description: Offset of the DPTX PHY configuration registers.

quoted

+      - description: Offset of the SD0801 PHY configuration registers.

quoted

+

quoted

+  "#phy-cells":

quoted

+    const: 0

quoted

+

quoted

+  num_lanes:

quoted

+    description:

quoted

+      Number of DisplayPort lanes.

quoted

+    allOf:

quoted

+      - $ref: /schemas/types.yaml#/definitions/uint32

quoted

+      - enum: [1, 2, 4]

quoted

+

quoted

+  max_bit_rate:

quoted

+    description:

quoted

+      Maximum DisplayPort link bit rate to use, in Mbps

quoted

+    allOf:

quoted

+      - $ref: /schemas/types.yaml#/definitions/uint32

quoted

+      - enum: [2160, 2430, 2700, 3240, 4320, 5400, 8100]

quoted

+

quoted

+required:

quoted

+  - compatible

quoted

+  - reg

quoted

+  - "#phy-cells"

quoted

+

quoted

+examples:

quoted

+  - |

quoted

+    dp_phy: phy@f0fb030a00 {

quoted

+          compatible = "cdns,torrent-phy";

quoted

+          reg = <0xf0 0xfb030a00 0x0 0x00000040>,

quoted

+                <0xf0 0xfb500000 0x0 0x00100000>;

quoted

+          num_lanes = <4>;

quoted

+          max_bit_rate = <8100>;

quoted

+          #phy-cells = <0>;

quoted

+    };

quoted

+...

quoted

--

quoted

2.7.4

quoted

Thanks & Regards 
Yuti Amonkar