On Wed, Nov 27, 2019 at 12:14:19PM +0100, Ondřej Jirman wrote:

quoted

+	/*
+	 * Avoid entering the interrupt handler, the thermal device is not
+	 * registered yet, we deffer the registration of the interrupt to
+	 * the end.
+	 */
+	ret = devm_request_threaded_irq(dev, irq, NULL,
+					sun8i_irq_thread,
+					IRQF_ONESHOT, "ths", tmdev);
+	if (ret)
+		return ret;
+
+	return ret;

I guess just return devm_request_threaded_irq(... ^

This is harder to extend though, so I'd keep the current construct
(with a return 0 though).

Thanks!
Maxime