Re: [PATCH v17 1/6] soc: mediatek: cmdq: fixup wrong input order of write api
From: CK Hu <hidden>
Date: 2019-11-22 08:06:08
Also in:
linux-arm-kernel, linux-mediatek, lkml
Hi, Bibby: On Thu, 2019-11-21 at 09:54 +0800, Bibby Hsieh wrote:
Fixup a issue was caused by the previous fixup patch.
Reviewed-by: CK Hu <redacted>
quoted hunk ↗ jump to hunk
Fixes: 1a92f989126e ("soc: mediatek: cmdq: reorder the parameter") Signed-off-by: Bibby Hsieh <redacted> --- drivers/soc/mediatek/mtk-cmdq-helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c index 7aa0517ff2f3..3c82de5f9417 100644 --- a/drivers/soc/mediatek/mtk-cmdq-helper.c +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c@@ -155,7 +155,7 @@ int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u8 subsys, err = cmdq_pkt_append_command(pkt, CMDQ_CODE_MASK, 0, ~mask); offset_mask |= CMDQ_WRITE_ENABLE_MASK; } - err |= cmdq_pkt_write(pkt, value, subsys, offset_mask); + err |= cmdq_pkt_write(pkt, subsys, offset_mask, value); return err; }