On Tue, Sep 17, 2019 at 08:25:55AM +0000, Biwen Li wrote:

quoted

Caution: EXT Email

Hi Biwen,

On Tue, Sep 17, 2019 at 10:09 AM Biwen Li [off-list ref] wrote:

quoted

The patch adds kohms unit

Signed-off-by: Biwen Li <redacted>

Thanks for your patch!

quoted

--- a/Documentation/devicetree/bindings/property-units.txt
+++ b/Documentation/devicetree/bindings/property-units.txt

@@ -27,6 +27,7 @@ Electricity
 -microamp      : microampere
 -microamp-hours : microampere hour
 -ohms          : ohm
+-kohms         : kiloohm
 -micro-ohms    : microohm
 -microwatt-hours: microwatt hour
 -microvolt     : microvolt

What's your rationale for adding "kohms"?
Do you need to specify resistance values that do not fit in 32-bit, and thus

32-bit is enough, I have three values, 60 kohm, 100 kohm and 500 kohm

quoted

cannot be specified using "ohms"?

If replace with ohms, the value is as follows:
60000 ohm, 100000 ohm, 500000 ohm.
It's so long for everyone.

It's not any longer, it's still 32-bits.

Please stick with '-ohms'.

Rob