Re: [PATCH v6 01/12] tools lib traceevent: Convert remaining %p[fF] users to %p[sS]
From: Sakari Ailus <sakari.ailus@linux.intel.com>
Date: 2019-09-18 13:08:44
Also in:
linux-acpi, lkml
From: Sakari Ailus <sakari.ailus@linux.intel.com>
Date: 2019-09-18 13:08:44
Also in:
linux-acpi, lkml
Hi Steven, On Mon, Sep 16, 2019 at 10:37:55AM -0400, Steven Rostedt wrote:
quoted
If you think that's an issue, I'll opt for another extension than %pfw, which I chose originally since it's memorable --- fw for fwnode (names, paths, and probably more in the future).I'm fine with the switch, as long as newer tools know how to handle it. Make sure we also add a comment in the Linux kernel code that states that older kernels use to have 'f' and 'F' and that new tools look for 'fw' to denote that this isn't an older kernel. This way, people will hopefully not add another 'fX' pointer name.
Good point. I'll add a comment on this to make_bprint_args() in tools/lib/traceevent/event-parse.c as well as in vsprintf.c. -- Regards, Sakari Ailus sakari.ailus@linux.intel.com